021 architecture remediation#10
Merged
timschwartz merged 5 commits intomainfrom Apr 14, 2026
Merged
Conversation
…fication and requirements checklist
… refining IChainReader, and standardizing error handling
…contract; add tasks documentation for architecture remediation
- Updated RpcServer to include IChainReader and IChainWriter references. - Changed SyncResponse structure to replace chunk_index with start_index. - Enhanced NodeInstance to instantiate ChainService and pass it to PeerManager and BlockPropagation. - Added ChainService tests to validate block submission and synchronization behavior. - Modified block propagation tests to utilize ChainService for block handling. - Implemented replaceChainStreaming in Blockchain to support streaming block replacement with validation. - Updated peer discovery and management tests to accommodate ChainService integration. - Adjusted sync tests to reflect changes in SyncResponse structure.
…ead of throwing exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.